Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split up CUDA-suffixed dependencies in dependencies.yaml #247

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. cudf depending on rmm, not rmm-cu12.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in dependencies.yaml.

For more details, see:

Notes for Reviewers

Why target 24.08?

This is targeting 24.08 because:

  1. it should be very low-risk
  2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 24, 2024
@jameslamb jameslamb changed the title WIP: split up CUDA-suffixed dependencies in dependencies.yaml split up CUDA-suffixed dependencies in dependencies.yaml Jul 24, 2024
@jameslamb jameslamb marked this pull request as ready for review July 24, 2024 05:47
@jameslamb jameslamb requested a review from a team as a code owner July 24, 2024 05:47
@jameslamb jameslamb requested a review from msarahan July 24, 2024 05:47
@jameslamb
Copy link
Member Author

I've updated this based on the suggestions from rapidsai/cudf#16183.

Ran the following to check update-version.sh.

git fetch upstream --tags
ci/release/update-version.sh '24.10.00'

git grep -E '24\.8|24\.08'

Did not find any required changes for that script.

@jameslamb
Copy link
Member Author

It looks like the pip devcontainer build here is now failing like this:

  /home/coder/cuvs/cpp/src/neighbors/./detail/knn_brute_force.cuh(597): error: no instance of overloaded function "raft::detail::popc" matches the argument list
              argument types are: (const raft::resources, std::experimental::mdspan<const uint32_t, std::experimental::extents<int64_t, 18446744073709551615UL>, raft::layout_c_contiguous, raft::host_device_accessor<std::experimental::default_accessor<const uint32_t>, raft::memory_type::device>>, long, std::experimental::mdspan<int64_t, std::experimental::extents<uint32_t, 1UL>, raft::layout_c_contiguous, raft::host_device_accessor<std::experimental::default_accessor<int64_t>, raft::memory_type::device>>)
      raft::detail::popc(res, filter_view, n_queries * n_dataset, nnz_view);

(build link)

I see the same error on other recent PRs, like #246 (build link), so strongly suspect it's not related to these changes and that this PR would be safe to admin-merge.

@jameslamb
Copy link
Member Author

Cancelling CI here (and will on other commits in the next 24 hours) to save some CI capacity for other projects that are about to enter code freeze.

@jameslamb
Copy link
Member Author

This will be blocked until #249 is merged.

Seeing builds fail like this:

  In file included from /__w/cuvs/cuvs/cpp/src/neighbors/brute_force.cu:17:
  /__w/cuvs/cuvs/cpp/src/neighbors/./detail/knn_brute_force.cuh:31:10: fatal error: raft/core/detail/popc.cuh: No such file or directory
     31 | #include <raft/core/detail/popc.cuh>
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~

(build link)

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 337c696 into rapidsai:branch-24.08 Jul 26, 2024
54 checks passed
@jameslamb jameslamb deleted the suffix-split branch July 26, 2024 20:23
divyegala pushed a commit to divyegala/cuvs that referenced this pull request Jul 31, 2024
Contributes to rapidsai/build-planning#31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. `cudf` depending on `rmm`, not `rmm-cu12`.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in `dependencies.yaml`.

For more details, see:
* rapidsai/build-planning#31 (comment)
* rapidsai/cudf#16183

This is targeting 24.08 because:

1. it should be very low-risk
2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#247
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants