-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell as a linter #992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmake
Related to CMake code or build configuration
Java
Related to Java code
libcuspatial
Relates to the cuSpatial C++ library
Python
Related to Python code
labels
Mar 14, 2023
bdice
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
cmake
Related to CMake code or build configuration
Python
Related to Python code
libcuspatial
Relates to the cuSpatial C++ library
Java
Related to Java code
and removed
cmake
Related to CMake code or build configuration
Python
Related to Python code
libcuspatial
Relates to the cuSpatial C++ library
Java
Related to Java code
labels
Mar 14, 2023
harrism
approved these changes
Mar 14, 2023
isVoid
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1000000
It's actually not quite a million lines of code. Only +58/-41. 😉 (kidding) Thanks for the review. I'll merge now. |
/merge |
raydouglass
approved these changes
Mar 14, 2023
trxcllnt
pushed a commit
to trxcllnt/cuspatial
that referenced
this pull request
Mar 15, 2023
Following the example of rapidsai/cudf#12097, this PR adds [codespell](https://github.com/codespell-project/codespell) as a linter for cuspatial. Note: I have not included a section in the CONTRIBUTING.md about how to use this (as was done in cudf's PR) because I plan to overhaul the contributing guides for all RAPIDS repos in the near term, and have a single source in docs.rapids.ai with common information about linters used in RAPIDS. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Michael Wang (https://github.com/isVoid) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmake
Related to CMake code or build configuration
improvement
Improvement / enhancement to an existing function
Java
Related to Java code
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Python
Related to Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the example of rapidsai/cudf#12097, this PR adds codespell as a linter for cuspatial.
Note: I have not included a section in the CONTRIBUTING.md about how to use this (as was done in cudf's PR) because I plan to overhaul the contributing guides for all RAPIDS repos in the near term, and have a single source in docs.rapids.ai with common information about linters used in RAPIDS.
Checklist