Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codespell as a linter #992

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 14, 2023

Description

Following the example of rapidsai/cudf#12097, this PR adds codespell as a linter for cuspatial.

Note: I have not included a section in the CONTRIBUTING.md about how to use this (as was done in cudf's PR) because I plan to overhaul the contributing guides for all RAPIDS repos in the near term, and have a single source in docs.rapids.ai with common information about linters used in RAPIDS.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested review from a team as code owners March 14, 2023 04:56
@bdice bdice self-assigned this Mar 14, 2023
@github-actions github-actions bot added cmake Related to CMake code or build configuration Java Related to Java code libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Mar 14, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library Java Related to Java code and removed cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library Java Related to Java code labels Mar 14, 2023
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1000000

@bdice
Copy link
Contributor Author

bdice commented Mar 14, 2023

+1000000

It's actually not quite a million lines of code. Only +58/-41. 😉 (kidding) Thanks for the review. I'll merge now.

@bdice
Copy link
Contributor Author

bdice commented Mar 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit 95350b9 into rapidsai:branch-23.04 Mar 14, 2023
trxcllnt pushed a commit to trxcllnt/cuspatial that referenced this pull request Mar 15, 2023
Following the example of rapidsai/cudf#12097, this PR adds [codespell](https://github.com/codespell-project/codespell) as a linter for cuspatial.

Note: I have not included a section in the CONTRIBUTING.md about how to use this (as was done in cudf's PR) because I plan to overhaul the contributing guides for all RAPIDS repos in the near term, and have a single source in docs.rapids.ai with common information about linters used in RAPIDS.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Michael Wang (https://github.com/isVoid)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#992
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function Java Related to Java code libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants