Remove GDAL dependency in quadtree spatial join tests. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmake
harrism
changed the title
harrism
added
improvement
isVoid
approved these changes
Mar 7, 2023
| std::uint32_t bits = hits_host[point_index]; | ||
| while (bits != 0) { | ||
| std::uint32_t t = bits & -bits; // get only LSB | ||
| std::uint32_t poly_index = __builtin_ctzl(bits); // get index of LSB |
There was a problem hiding this comment.
Since it's int type here, shouldn't the most compatible function is __builtin_ctz instead of __builtin_ctzl?
thomcom
approved these changes
Mar 7, 2023
harrism
added
the
5 - Merge After Dependencies
trxcllnt
reviewed
Mar 8, 2023
trxcllnt
approved these changes
Mar 8, 2023
|
/merge |
jjacobelli
approved these changes
Mar 13, 2023
trxcllnt
pushed a commit
to trxcllnt/cuspatial
that referenced
this pull request
Mar 15, 2023
Closes rapidsai#958. Replaces usage of GDAL `contains` in the quadtree point-in-polygon tests with a call to a different cuSpatial point-in-polygon function. This allows us to remove all current dependencies on GDAL in cuSpatial. Depends on rapidsai#973. This PR currently updates some expectations to make tests pass that are fixed in that PR. Authors: - Mark Harris (https://github.com/harrism) Approvers: - Michael Wang (https://github.com/isVoid) - H. Thomson Comer (https://github.com/thomcom) - Paul Taylor (https://github.com/trxcllnt) - Jordan Jacobelli (https://github.com/jjacobelli) URL: rapidsai#974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #958. Replaces usage of GDAL
containsin the quadtree point-in-polygon tests with a call to a different cuSpatial point-in-polygon function. This allows us to remove all current dependencies on GDAL in cuSpatial.Depends on #973. This PR currently updates some expectations to make tests pass that are fixed in that PR.
Checklist