Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Notebook with GeoSeries Usage and Add Notebook Tests #953

Merged
merged 8 commits into from
Feb 24, 2023
Merged

Update Notebook with GeoSeries Usage and Add Notebook Tests #953

merged 8 commits into from
Feb 24, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 22, 2023 •
edited
Loading

Description

Adds notebooks test for cuspatial.

This PR also refactors the notebooks in cuSpatial to reflect the recent GeoSeries refactor effort. Closes #935

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner February 22, 2023 23:40
@github-actions github-actions bot added the ci label Feb 22, 2023
@isVoid isVoid added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 22, 2023
@harrism harrism mentioned this pull request Feb 23, 2023
Closed
ajschmidt8
ajschmidt8 reviewed Feb 23, 2023
View reviewed changes
ci/test_notebooks.sh Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 reviewed Feb 23, 2023
View reviewed changes
ci/utils/nbtest.sh Outdated Show resolved Hide resolved
@isVoid isVoid linked an issue Feb 23, 2023 that may be closed by this pull request
[FEA]: Test notebooks in CI #954
Closed
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the Python Related to Python code label Feb 23, 2023
@isVoid isVoid changed the title Add Notebook Tests Update Notebook with GeoSeries Usage and Add Notebook Tests Feb 23, 2023
@isVoid isVoid requested review from ajschmidt8 and thomcom February 23, 2023 23:02
ajschmidt8
ajschmidt8 reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor piece of clean up after implementing the trap error handling.

ci/test_notebooks.sh Outdated Show resolved Hide resolved
@isVoid isVoid requested a review from ajschmidt8 February 24, 2023 00:34
@isVoid
Copy link
Contributor Author

isVoid commented Feb 24, 2023

/merge

@rapids-bot rapids-bot bot merged commit 19b2bb2 into rapidsai:branch-23.04 Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@thomcom thomcom thomcom approved these changes

Assignees

@bdice bdice

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Test notebooks in CI Update user guide notebook to reflect geoseries refactor effort
4 participants
@isVoid @thomcom @ajschmidt8 @bdice