Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add from_linestrings_xy and from_polygons_xy #928

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Feb 14, 2023

Depends on #924

Description

Provides public GeoSeries methods to create single-type GeoSeries for linestrings and polygons in addition to the points and multipoints methods added in #924.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@thomcom thomcom requested a review from a team as a code owner February 14, 2023 20:17
@thomcom thomcom requested a review from isVoid February 14, 2023 20:17
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the Python Related to Python code label Feb 14, 2023
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many changes from #924. If we agree we merge that PR first, then it should be fine.

python/cuspatial/cuspatial/core/geoseries.py Outdated Show resolved Hide resolved
python/cuspatial/cuspatial/core/geoseries.py Outdated Show resolved Hide resolved
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Feb 14, 2023
@harrism
Copy link
Member

harrism commented Feb 15, 2023

I'll review once you merge the latest from 23.04 so I don't have to figure out which changes to review.

@thomcom
Copy link
Contributor Author

thomcom commented Feb 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit aae60ba into rapidsai:branch-23.04 Feb 15, 2023
rapids-bot bot pushed a commit that referenced this pull request Feb 23, 2023
This PR refactors `[polygon|linestring]_bounding_boxes` API to accept geoseries input.
closes #929 closes #930

depends on #928

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants