-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add from_linestrings_xy
and from_polygons_xy
#928
Add from_linestrings_xy
and from_polygons_xy
#928
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many changes from #924. If we agree we merge that PR first, then it should be fine.
I'll review once you merge the latest from 23.04 so I don't have to figure out which changes to review. |
/merge |
This PR refactors `[polygon|linestring]_bounding_boxes` API to accept geoseries input. closes #929 closes #930 depends on #928 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) - H. Thomson Comer (https://github.com/thomcom) URL: #934
Depends on #924
Description
Provides public GeoSeries methods to create single-type GeoSeries for linestrings and polygons in addition to the points and multipoints methods added in #924.
Checklist