-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs build job #868
Add docs build job #868
Conversation
Codecov ReportBase: 92.60% // Head: 92.60% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #868 +/- ##
=============================================
Coverage 92.60% 92.60%
=============================================
Files 24 24
Lines 1014 1014
=============================================
Hits 939 939
Misses 75 75 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
78fc319
to
74a7c7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added a few comments
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these inline pydocs changes purposeful? I ask because it seems like there would be a lot more changes across the codebase to match the new formatting requirement, if there is one.
@thomcom, we've enabled the It seems like there are only 11 warnings and they all look whitespace related, so it shouldn't be too hard for us to address them in this PR. If it gets out of hand, we can address them in a follow-up PR. |
According to the [`autodoc` documentation](https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html), `autodoc` will automatically import the modules to be documented. The CI docs building process will install the packages that were built in previous stages of the workflow and presumably `autodoc` will import those correctly, which means these lines are not needed.
I've just pushed a few additional changes and some reversions. I think this is almost the minimum set of changes needed to build the docs without any warnings. I'm expecting the latest commit as of this writing (4f60b18) to throw a Once that happens, I will push the change below to suppress it since it's a relatively benign warning. suppress_warnings = [
"autosectionlabel.*"
] It stems from the fact that the https://docs.rapids.ai/api/cuspatial/nightly/user_guide/cuspatial_api_examples.html page has two section headers called As a result of this, the first occurrence gets a correct anchor attached, but the second occurrence gets an anchor of
The consequence of this is that you can't confidently link to either section using the However, I didn't see any instances of @thomcom, I'll defer to you to determine if you want to leave the |
We can also just remove the I will check that locally. |
I'd be interested in addressing the warnings in a follow up PR, we can chat about how to get my pre-commit set up to give me docs warnings in addition to the normal commit errors. Given that |
@thomcom, I just pushed two changes based on your reply. Can you review / approve this PR when you have a moment? It should be good to go now. |
/merge |
The PR adds a
docs_build
process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.