Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated lonlat_to_cartesian functions #842

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Remove deprecated lonlat_to_cartesian functions #842

merged 3 commits into from
Dec 7, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Dec 6, 2022 •
edited
Loading

Closes #796

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested review from a team as code owners December 6, 2022 05:01
@harrism harrism requested review from isVoid and jrhemstad December 6, 2022 05:01
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added Java Related to Java code libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Dec 6, 2022
@harrism harrism added improvement Improvement / enhancement to an existing function breaking Breaking change labels Dec 7, 2022
isVoid
isVoid approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@harrism
Copy link
Member Author

harrism commented Dec 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 138dc69 into rapidsai:branch-23.02 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@thomcom thomcom thomcom approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function Java Related to Java code libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DEPRECATION]: Remove lonlat_to_cartesian
3 participants
@harrism @thomcom @isVoid