-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dependency List with dependencies.yaml
[skip gpuci]
#803
Update Dependency List with dependencies.yaml
[skip gpuci]
#803
Conversation
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
dependencies.yaml
Outdated
includes: | ||
- build | ||
- develop | ||
- py_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style checks should not be dependent on a specific Python version being specified in the matrix (if no value is specified, the matrix match will fail). The Python requirement in the build
list should be sufficient. However, we may want a default (empty matrix in the last entry) of py_version
defining >=3.8,<3.10
instead of putting it in build
.
- py_version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason doing it just for py_version? Why not also cython?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And are you suggesting removing python
entry from build
and use py_version
in all
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you did what I wanted -- remove py_version
from the style check dependency list.
As for removing python
from build
-- is there a C++ library that can be built without Python? If so, I would remove python
, cython
, ... from build
and put them in a separate list like build_python
. We're trying to achieve a level of modularity/granularity that is useful for minimizing dependencies at each stage of a build.
- conda-forge | ||
- nvidia | ||
dependencies: | ||
- cmake>=3.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- cmake>=3.23.1 | |
- cmake>=3.23.1,!=3.25.0 |
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com> Co-authored-by: Bradley Dice <bdice@bradleydice.com>
these will be needed for the GH Actions workflows, so might as well add them now.
@bdice, I just pushed some changes. I'll defer to you to add these necessary dependencies. Otherwise, I think this PR looks good to me! |
dependencies.yaml
dependencies.yaml
[skip gpuci]
…nto conda/dependency_yaml
@ajschmidt8 Feel free to merge if you think this is ready, then we can start the GitHub Actions migration. I checked the current CI workflows and I think we have already handled all the features that the cuSpatial repo will need. |
Description
This PR updates dependency lists with
dependencies.yaml
.Checklist