Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force using old fmt in nvbench. #783

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Force using old fmt in nvbench. #783

merged 1 commit into from
Nov 7, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 7, 2022 •
edited
Loading

Description

This is a port of rapidsai/cudf#12067.

Original post:

The current version of nvbench is not compatible with the latest changes to fmt. This PR decouples us from needing to wait on upstreaming the compatibility changes to nvbench. These changes are necessary for building libcudf benchmarks until then.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner November 7, 2022 18:40
@isVoid isVoid requested a review from harrism November 7, 2022 18:40
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Nov 7, 2022
@isVoid isVoid requested a review from thomcom November 7, 2022 18:41
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change labels Nov 7, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit aab7d86 into rapidsai:branch-22.12 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

Assignees
No one assigned
Labels
bug Something isn't working cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isVoid @thomcom