-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ULP Based Floating Point Equality Test to Device Function #773
Merged
rapids-bot
merged 2 commits into
rapidsai:branch-22.12
from
isVoid:feature/ulp_based_equal
Nov 7, 2022
Merged
Introduce ULP Based Floating Point Equality Test to Device Function #773
rapids-bot
merged 2 commits into
rapidsai:branch-22.12
from
isVoid:feature/ulp_based_equal
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
requested review from
trxcllnt and
zhangjianting
and removed request for
trxcllnt
November 3, 2022 04:54
isVoid
added
non-breaking
Non-breaking change
feature request
New feature or request
labels
Nov 3, 2022
3 tasks
thomcom
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, I'm really impressed.
harrism
requested changes
Nov 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful!
rerun tests |
harrism
approved these changes
Nov 7, 2022
@gpucibot merge |
3 tasks
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
#773 added a test utility that checks floating point equality based on ULP difference. However, as a blinded file checkout in #786, the line that builds tests for the floating point utility is removed by mistake. This PR adds that back. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) URL: #812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
cmake
Related to CMake code or build configuration
feature request
New feature or request
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
float_eq_by_ulp
utility to allow practical near equality for floating point computation in device code.In GIS application, near equal is often required due to rounding error of floating point and may wrong categorization of line collinearity or point on line test.
Using this test does not incur visible performance degradation:
Note that the run time is very small in time scale so the result is very noisy. The average time difference is very small though.
Checklist