Refactor of pairwise_linestring_distance to use multilinestring_range, adds support to multilinestring distance
#755
Conversation
isVoid
added
3 - Ready for Review
isVoid
requested review from
trxcllnt,
zhangjianting,
thomcom and
harrism
and removed request for
trxcllnt and
zhangjianting
| thrust::next(_part_begin + _geometry_begin[i + 1]), | ||
| _point_begin, | ||
| _point_end}; | ||
| } |
There was a problem hiding this comment.
Curious what you're using this for. A constructor that returns a slice of a multilinestring_range?
There was a problem hiding this comment.
That's right. This is for the element accessor of multilinestirng_range. When you access a single element in multilinestring_range, you get a single multilinestring.
| return _point_end; | ||
| } | ||
|
|
||
| } // namespace cuspatial |
There was a problem hiding this comment.
What is the difference between a multilinestring_range and a multilinestring_ref?
There was a problem hiding this comment.
Conceptually multilinestring_range is a non-owning object on an array of multilinestrings.
multilinestring_ref is just a non owning object to a single multilinestring. Iterating on multilinestring_range gives a multilinestring_ref.
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
…into feature/multilinestring_distance_header_only
cpp/include/cuspatial/experimental/detail/geometry/linestring_ref.cuh
Outdated
Show resolved
Hide resolved
cpp/include/cuspatial/experimental/geometry_collection/multipoint_ref.cuh
Outdated
Show resolved
Hide resolved
|
rerun tests |
1 similar comment
|
rerun tests |
|
@gpucibot merge |
Description
Note, this is the first part of
pairwise_linestring_distancerefactoring, part 1 of PR: #753Depends on #752
Contributes to #706, #703
Closes #745
Checklist