-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GeoSeries.contains_properly
method using point_in_polygon.
#749
Merged
rapids-bot
merged 104 commits into
rapidsai:branch-22.12
from
thomcom:feature/GeoSeries.contains
Nov 30, 2022
Merged
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
758c66b
Add tests to verify border-exclusion and modify point_in_polygon.cuh …
thomcom 731987b
Merge branch 'feature/pip_boundary_exclusion_test' into feature/GeoSe…
thomcom 76c8b1d
Trying to write contains tests, having difficulties.
thomcom beacf76
Pass all clockwise polygon tests.
thomcom 67d6153
Test of boundary exclusion.
thomcom 8a19829
Create is_point_colinear_with_polygon method. Get colinearity working.
thomcom d2f93ed
Merge branch 'feature/GeoSeries.contains' into test-contains
thomcom 7cce26b
Tweak one test because it shares a point with the offending polygon.
thomcom 11be135
Modify colinearity test to early terminate.
thomcom 5aa9c09
Create a point_in_polygon_one_to_one for better correspondence with c…
thomcom a9c1806
Wresling with pre-commit.
thomcom 1b4f850
Rename to pairwise.
thomcom cba43a4
Need to include the proper file.
thomcom fbfd0b7
Move shared is_point_in_polygon to its own file.
thomcom a0cfbe2
Remove unneeded includes.
thomcom 046e4a1
Fix the tests that should no longer pass.
thomcom c87e741
Fix the tests that should no longer pass.
thomcom 7f1b632
Now we allow open or closed polygons again.
thomcom cd205b2
Write tests for pairwise point in polygon.
thomcom 121e146
Create new branch with pairwise_point_in_polygon cpp changes.
thomcom 756282d
Clean up docs on cursory review.
thomcom f5f7777
Use T as TypeParam
thomcom ebb266e
Merge
thomcom e784307
Writing tests and implementation for polygon/point contains.
thomcom 2eb4b9d
Merge branch 'branch-22.12' into feature/GeoSeries.contains
thomcom f53acec
Create polygon and multipolygon generator.
thomcom 390890d
Refactor and create exhaustive polygon contains tests.
thomcom a6f8f69
Add epsilon to colinearity test.
thomcom 87020fa
Formatting.
thomcom 08e845b
Merge branch 'feature/pairwise_point_in_polygon' into feature/GeoSeri…
thomcom 9b2a69b
Boundary cases that are inconsistent.
thomcom 3a34016
Add EPSILON and refactor some tests.
thomcom e8af434
Remove stale comment.
thomcom 70437da
Correct comments
thomcom 1028860
Merge branch 'feature/pairwise_point_in_polygon' into feature/GeoSeri…
thomcom 832167f
Add polygon.contains(linestring)
thomcom cc87c86
Test points in polygons.
thomcom 1fdd921
Revert "Merge branch 'feature/pairwise_point_in_polygon' into feature…
thomcom 8e8bc81
Fixed
thomcom 0efb650
Add the polygon with a hole with a linestring crossing it case.
thomcom a092a6e
Add polygons and multilinestrings and some known failure cases.
thomcom c55ac72
Rename is_point_in_polygon.cuh
thomcom 5624068
Keep only colinearity epsilon.
thomcom 9bb615b
Revert "Merge branch 'feature/pairwise_point_in_polygon' into feature…
thomcom d27672d
Merge branch 'branch-22.12' into feature/GeoSeries.contains
thomcom 7550399
Change to grid/stride loop.
thomcom 8786614
Merge branch 'branch-22.12' into feature/pairwise_point_in_polygon
thomcom be5a5c0
Fix bug with grid-stride loop and switch to for comparison.
thomcom f7bbf10
Update cpp/include/cuspatial/pairwise_point_in_polygon.hpp
thomcom b6d55b8
Update cpp/include/cuspatial/experimental/pairwise_point_in_polygon.cuh
thomcom d3d7533
Update cpp/include/cuspatial/experimental/pairwise_point_in_polygon.cuh
thomcom 0edd2df
run-clang-format.py
thomcom 1c02f3c
Improve grid stride loop computations.
thomcom 89169ee
Update cpp/include/cuspatial/experimental/detail/is_point_in_polygon.cuh
thomcom e5e937f
Merge branch 'feature/pairwise_point_in_polygon' of github.com:thomco…
thomcom 332d5c0
Merge
thomcom 0cf4602
Resolve circular import issue.
thomcom 66000c3
Pass pytests and refactor to got/expected pattern.
thomcom 88312c9
Add one more test case.
thomcom 2c893d3
Write detailed xfail descriptions.
thomcom f81ac93
Update python/cuspatial/cuspatial/_lib/cpp/pairwise_point_in_polygon.pxd
thomcom 104657f
Update python/cuspatial/cuspatial/_lib/pairwise_point_in_polygon.pyx
thomcom 4bd3f49
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom 0cdb9f3
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom 437eea9
Tweak a comment.
thomcom ec545ac
Add comments back to generators.
thomcom 4aa4064
Write more fixture docs.
thomcom 8691e5e
Reorder got/expected.
thomcom 1139316
Update one more test description.
thomcom e62aa9f
Create .contains examples.
thomcom 22b9241
Move .contains docs to geoseries.py
thomcom 597d932
Remove binops with quadtree.
thomcom 70a4991
Fix test issue with sporadic groupby reordering.
thomcom 104912d
Fix benchmark regression from 22.12
thomcom fee62b9
Fix bug with benchmark point_in_polygon
thomcom 0b1dc79
Poly offsets is n+1 the size of points.
thomcom 166ecb3
Update python/cuspatial/cuspatial/tests/test_contains.py
thomcom 9e8892a
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom 166c5cf
Update python/cuspatial/cuspatial/tests/conftest.py
thomcom e92686d
Update python/cuspatial/cuspatial/tests/conftest.py
thomcom 88b864d
DRY-ify a function.
thomcom 85b2dab
Merge branch 'feature/GeoSeries.contains' of github.com:thomcom/cuspa…
thomcom 726e637
Merge branch 'branch-22.12' into feature/GeoSeries.contains
thomcom 61c48e2
Handling @isVoid's comments.
thomcom 903e0ae
Rename to contains_properly
thomcom dea2b96
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom ad308fb
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom 0854a65
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom cd6bd66
Handle more review comments.
thomcom 141b86c
Merge branch 'feature/GeoSeries.contains' of github.com:thomcom/cuspa…
thomcom d72df1c
Comment
thomcom d08ad01
Fix alignment.
thomcom cb1b149
Fix example layout again.
thomcom 8db29b6
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom f31b70e
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom 80f5ea1
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom 4a594b9
Apply suggestions from code review
thomcom 4a651f1
Get rid of GeoPandas round trip in .contains_properly example and fix…
thomcom d401c58
Merge branch 'feature/GeoSeries.contains' of github.com:thomcom/cuspa…
thomcom 1c4f1bc
Style issue, black is hopefully not breaking flake8 in CI.
thomcom d007515
Add __init__.py to binops hoping to resolve CI issue.
thomcom 91c09af
Need test_contains_properly.py
thomcom 0d32a64
Remove xfails.
thomcom 70822a8
Update python/cuspatial/cuspatial/core/geoseries.py
thomcom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in a
Note
section as well?