Fix all unexecutable code examples I can find. #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcom
commented
Sep 26, 2022
| @@ -133,7 +133,8 @@ def _split_out_geometry_columns(self) -> Tuple: | |||
| """ | |||
| columns_mask = pd.Series(self.columns) | |||
| geocolumn_mask = pd.Series( | |||
| [isinstance(self[col], GeoSeries) for col in self.columns] | |||
| [isinstance(self[col], GeoSeries) for col in self.columns], | |||
| dtype="bool", | |||
There was a problem hiding this comment.
Pandas was issuing a warning on this line so I corrected that warning.
thomcom
added
bug
harrism
requested review from
harrism and
isVoid
and removed request for
cwharris
harrism
approved these changes
Sep 27, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few old issues that are tasked for
22.10involve fixing documentation that is incorrect. I worked through the existing nightly docs and executed all of the code samples, fixing and improving anything that had incorrect outputs or inputs.closes #460
closes #63
Checklist