Expand expect_vector_equivalent to handle std::vector of vec_2d<T> and move traits out of detail #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
tests
isVoid
approved these changes
Sep 13, 2022
harrism
changed the title
isVoid
approved these changes
Sep 14, 2022
|
Lots of nice refactoring of old test code too... Nice improvement. |
|
@gpucibot merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
Converting from `EXPECT_EQ` to `expect_vector_equivalent` (#669) caused `coordinate_transform_test` to fail due to floating point differences. It's strange that it passed with exact equality testing (perhaps a problem in Thrust?). In any case, this fixes the test data generation and DRYs up the tests a bit. Authors: - Mark Harris (https://github.com/harrism) Approvers: - H. Thomson Comer (https://github.com/thomcom) - Michael Wang (https://github.com/isVoid) URL: #671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
expect_vector_equivalentto support comparing vectors ofvec_2d<T>with approximate comparison of floating point equality (using GTEST functionality). This function now also explicitly copies all vectors to the host for comparison.EXPECT_EQ.detailnamespace so they are more easily used in tests and user code.TODO:
- [ ]This will be fixed in a followup PR -- we discovered the test is flawed.coordinate_transform_testfails with this change, so I have not committed it. Something is different withEXPECT_EQand this function for that test. Investigating.Checklist