Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Statically link all CUDA toolkit libraries #665

Merged
merged 1 commit into from
Sep 19, 2022
Merged

[FEA] Statically link all CUDA toolkit libraries #665

merged 1 commit into from
Sep 19, 2022

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Sep 1, 2022

This PR ensures cuSpatial statically links all the CUDA toolkit libraries (not just cudart) if a user enables CUDA_STATIC_RUNTIME.

@trxcllnt trxcllnt requested a review from a team as a code owner September 1, 2022 19:40
@trxcllnt trxcllnt requested a review from harrism September 1, 2022 19:40
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Sep 1, 2022
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 1, 2022
harrism
harrism approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@harrism
Copy link
Member

harrism commented Sep 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit aadcbb3 into rapidsai:branch-22.10 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @harrism