Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids-cmake for builds #515

Merged
merged 11 commits into from
Apr 27, 2022
Merged

Use rapids-cmake for builds #515

merged 11 commits into from
Apr 27, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 7, 2022

Using rapids-cmake helps reduce duplication across different RAPIDS projects and makes various configuration aspects simpler.

@vyasr vyasr added 2 - In Progress Currenty a work in progress cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2022
@vyasr vyasr self-assigned this Apr 7, 2022
@vyasr vyasr requested review from a team as code owners April 7, 2022 22:16
@github-actions github-actions bot added libcuspatial Relates to the cuSpatial C++ library gpuCI Related to Continuous Integration / Automation java labels Apr 7, 2022
@vyasr vyasr marked this pull request as draft April 7, 2022 22:16
@vyasr vyasr requested a review from robertmaynard April 7, 2022 22:17
@vyasr
Copy link
Contributor Author

vyasr commented Apr 7, 2022

@robertmaynard I think this PR is mostly OK. The main area where I am very uncertain that I did everything right is with the exporting of dependencies for the creation of the config files, so please check through that part extra carefully. I also have TODOs scattered throughout the changes where I wasn't sure how to proceed, so let me know what you think of those.

robertmaynard
robertmaynard requested changes Apr 11, 2022
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/CUSPATIAL_GetCUDF.cmake Outdated Show resolved Hide resolved
@vyasr vyasr marked this pull request as ready for review April 12, 2022 21:10
@vyasr vyasr requested a review from robertmaynard April 12, 2022 21:15
@vyasr vyasr added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Apr 14, 2022
ajschmidt8
ajschmidt8 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

robertmaynard
robertmaynard requested changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice. Only one issue left

cpp/cmake/thirdparty/CUSPATIAL_GetCUDF.cmake Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from robertmaynard April 27, 2022 15:03
@vyasr
Copy link
Contributor Author

vyasr commented Apr 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 773b400 into rapidsai:branch-22.06 Apr 27, 2022
@vyasr vyasr deleted the enable_rapids_cmake branch April 27, 2022 18:29
@harrism
Copy link
Member

harrism commented Apr 27, 2022

Thanks for doing this @vyasr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @harrism @robertmaynard @ajschmidt8