Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pairwise_polygon_distance #504

Closed
wants to merge 9 commits into from
Closed

Support pairwise_polygon_distance #504

wants to merge 9 commits into from

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Mar 25, 2022 •
edited
Loading

This PR contributes to #231, and should supercede #251 .

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 25, 2022
@harrism
Copy link
Member

harrism commented Mar 28, 2022

Suggest separating clang-format to a standalone PR so that it gets its own line item in release notes and commit history.

@zhangjianting
Copy link
Contributor

Just a comment from application perspective: while Hausdorff distance matrix can be used as the input of clustering algorithms to group trajectories, it would be a little difficult to figure out a practical geospatial application that requires pair-wise distance matrix for a set of polygons (clustering/grouping polygons based purely on distance does not make a good geospatial application).
It could be more useful to compute distances for a vector of polygon pairs, i.e., vectorized computation of polygon-polygon distances, even though it is still much less frequently used than point-to-point, point-to-polyline and polyline-to-polyline distance.

@zhangjianting
Copy link
Contributor

zhangjianting commented Mar 28, 2022 •
edited
Loading

For test, I would suggest verify polygon-polygon distance result by comparing against libgeos result, as that would be the what geospaital community expects.

@isVoid isVoid changed the title Support polygon_distance Support pairwise_polygon_distance Mar 30, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Mar 30, 2022 •
edited
Loading

@zhangjianting out of scope of this PR. For polyline-polyline distance (and the rest more popular variants), do you consider the API should compute the matrix from a set of polylines or vectorize from a pair of polylines?

robertmaynard
robertmaynard approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes LGTM

@isVoid isVoid changed the base branch from branch-22.04 to branch-22.06 March 31, 2022 22:32
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This PR has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates.

@jarmak-nv jarmak-nv added this to the ST_Distance milestone Aug 2, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Apr 14, 2023

closing in favor of #1074

@isVoid isVoid closed this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library
Projects
cuSpatial
Status: Done
Milestone
ST_Distance
Development

Successfully merging this pull request may close these issues.
5 participants
@isVoid @harrism @zhangjianting @robertmaynard @jarmak-nv