Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuSpatial to use C++17 #382

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Update cuSpatial to use C++17 #382

merged 2 commits into from
Apr 13, 2021

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Apr 13, 2021 •
edited
Loading

cuDF 0.20 headers now use C++17 features, so we need to update to C++17 also.

We will also need to update CI images to use gcc-9, as C++17 support is incomplete in gcc-7 and gcc-8.

@trxcllnt trxcllnt requested review from a team as code owners April 13, 2021 16:02
@github-actions github-actions bot added cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library java labels Apr 13, 2021
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function labels Apr 13, 2021
ajschmidt8
ajschmidt8 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@trxcllnt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6d7d0d0 into rapidsai:branch-0.20 Apr 13, 2021
@trxcllnt trxcllnt deleted the fix/use-c++17 branch April 13, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team breaking Breaking change cmake Related to CMake code or build configuration conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @cwharris @kkraus14 @ajschmidt8