Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin gdal to 3.1.x #339

Merged
merged 6 commits into from
Jan 15, 2021
Merged

[REVIEW] Pin gdal to 3.1.x #339

merged 6 commits into from
Jan 15, 2021

Conversation

weiji14
Copy link
Contributor

@weiji14 weiji14 commented Jan 13, 2021 •
edited
Loading

Bump gdal from 3.0.x to 3.1.x, fixes #327 and supersedes/reverts #245.

@weiji14 weiji14 requested a review from a team as a code owner January 13, 2021 10:55
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@harrism
Copy link
Member

harrism commented Jan 13, 2021

okay to test

@harrism harrism added conda Related to conda and conda configuration non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jan 13, 2021
ajschmidt8
ajschmidt8 requested changes Jan 14, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the gdal version will also need to be updated in the integration repo (link below). Please open a PR there before this can be approved/merged.

https://github.com/rapidsai/integration/blob/branch-0.18/conda/recipes/versions.yaml#L71-L72

CHANGELOG.md Outdated Show resolved Hide resolved
@weiji14 weiji14 mentioned this pull request Jan 14, 2021
Merged
@kkraus14
Copy link
Contributor

Please update the GDAL version here (https://github.com/rapidsai/cuspatial/blob/branch-0.18/ci/gpu/build.sh#L46-L48) to confirm everything works as expected

@kkraus14
Copy link
Contributor

ok to test

@weiji14
Copy link
Contributor Author

weiji14 commented Jan 15, 2021

Great, thanks everyone for pointing me to all the different places! Do we need to merge rapidsai/integration#204 before this PR? And now that all the tests pass, can I revert the build.sh change?

@kkraus14
Copy link
Contributor

Great, thanks everyone for pointing me to all the different places! Do we need to merge rapidsai/integration#204 before this PR? And now that all the tests pass, can I revert the build.sh change?

Yup, merged the integration PR. Revert the build.sh change and we should be good to go.

ajschmidt8
ajschmidt8 approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved now that rapidsai/integration#204 is merged.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge 6 - Okay to Auto-Merge labels Jan 15, 2021
@rapids-bot rapids-bot bot merged commit 871c991 into rapidsai:branch-0.18 Jan 15, 2021
@weiji14 weiji14 deleted the gdal-3.1 branch January 15, 2021 04:23
@weiji14 weiji14 mentioned this pull request Feb 3, 2021
Merged
ajschmidt8 pushed a commit that referenced this pull request Mar 5, 2021
@weiji14
Pin gdal to 3.2.x (#347)
738ac78 
Bump `gdal` from 3.1.x to 3.2.x. Supersedes #339. This is inline with conda-forge's current migration to gdal=3.2.x (see conda-forge/conda-forge-pinning-feedstock#922 and https://conda-forge.org/status/#gdal32).

Update on rapidsai/integration is at rapidsai/integration#211.

Authors:
  - Wei Ji (@weiji14)

Approvers:
  - AJ Schmidt (@ajschmidt8)
  - Keith Kraus (@kkraus14)

URL: #347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Relax gdal < 3.1.0 pin
5 participants
@weiji14 @GPUtester @harrism @kkraus14 @ajschmidt8