Change download method for trajectory_clustering.ipynb's data for container testing #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wget no longer exists in our container. As per our notebook guidelines, for testing, every possible notebook should be testable. As we dropped wget from our container, we need to install it here. This code addition intelligently installs wget if necessary.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
harrism
requested changes
Feb 11, 2025
bdice
requested changes
Feb 11, 2025
There was a problem hiding this comment.
I would recommend one or more of the following alternatives, to avoid mucking up the notebook with apt commands (which may not be portable if run on non-Debian-based systems):
- remove this line https://github.com/rapidsai/docker/blob/c0679e4792950f0066ce64c314f47f9c6538278d/Dockerfile#L49 and leave wget installed in our base Docker images
- or list
wgetfrom conda-forge as a cuspatial notebook dependency, by specifying it here (next tocurl):Line 418 in 2e7f4fd
- or just modify the notebook to use
curl, which should already be installed
taureandyernv
changed the title
harrism
approved these changes
Feb 23, 2025
bdice
approved these changes
Feb 23, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wget no longer exists in our container. As per our notebook guidelines, for testing, every possible notebook should be testable. As we dropped wget from our container, we need to install it here. This code addition intelligently installs wget if necessary.