Make polygon fixture data valid #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For from shapely import get_coordinates
from itertools import chain
geom = gs[:9]
polys = geom[geom.apply(lambda x: isinstance(x, (MultiPolygon, Polygon)))]
coords = list(chain(polys.apply(get_coordinates)))
xy = list(chain(*coords))
x = [c[0] for c in coords]
y = [c[1] for c in coords] |
|
CI is blocked waiting for #1475 |
isVoid
reviewed
Oct 16, 2024
isVoid
approved these changes
Oct 16, 2024
Comment on lines
187
to
194
| polys_list = gs[gs.apply(lambda x: isinstance(x, (MultiPolygon, Polygon)))] | ||
| polys = list( | ||
| chain(polys_list.apply(get_coordinates)) | ||
| ) # flatten multigeometries | ||
| coords_list = list(chain(*polys)) # flatten geometries | ||
| xy_interleaved = list(chain(*coords_list)) # flatten coordinates | ||
| x = xy_interleaved[::2] | ||
| y = xy_interleaved[1::2] |
There was a problem hiding this comment.
Not something we need to fix in this PR, but it would be nice to abstract this into a helper.
There was a problem hiding this comment.
Agree, there is a lot of repetition.
There was a problem hiding this comment.
I assume you mean 1e96184? This looks much cleaner. Thanks!
|
I merged in the upstream to get CI fixes from #1475. |
Thanks. I take it you approve this PR? :) |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1471. Fixes the invalid polygon geometry and improves geometry slicing tests to not depend on hard-coded vertex positions that are also hard-coded in the fixture.
Checklist