Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused shuffle_order in GeoColumn #1439

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Remove unused shuffle_order in GeoColumn #1439

merged 1 commit into from
Aug 15, 2024

Conversation

mroeschke
Copy link
Contributor

Description

With rapidsai/cudf#16549, cudf.Index no longer accepts Column objects.

The only usage I found was that GeoColumn accepted shuffle_order=cudf.Index(column), but shuffle_order appears unused (anymore?) in GeoColumn, so I went ahead and removed this from the constructor

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner August 15, 2024 22:16
@mroeschke mroeschke requested review from harrism and isVoid August 15, 2024 22:16
@github-actions github-actions bot added the Python Related to Python code label Aug 15, 2024
@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Aug 15, 2024
@vyasr
Copy link
Contributor

vyasr commented Aug 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5842315 into rapidsai:branch-24.10 Aug 15, 2024
57 checks passed
@mroeschke mroeschke deleted the rm/geocolumn/shuffleorder branch August 16, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees

@mroeschke mroeschke

Labels
bug Something isn't working non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr