create conda ci test env in one step #1387
Conversation
| @@ -451,3 +457,16 @@ dependencies: | |||
| packages: | |||
| - cupy-cuda11x>=12.0.0 | |||
| - {matrix: null, packages: [cupy-cuda11x>=12.0.0]} | |||
| test_libcuspatial: | |||
There was a problem hiding this comment.
The naming on these things is really bad. I'm not sure what would be better. test_libcuspatial_includes? Suggestions would be most welcome!
There was a problem hiding this comment.
I find dependencies.yaml extremely confusing on the best days!
There was a problem hiding this comment.
(Sorry for the late response)
I would read test_libcuspatial as "Test dependencies for libcuspatial."
There was a problem hiding this comment.
Elsewhere in RAPIDS, we use depends_on_cudf, specifically for packages that are shipped by this repository. That might have been a better approach here, in retrospect.
msarahan
added
tests
msarahan
added
libcuspatial
|
Thanks Michael! 🙏 |
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
|
/merge |
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
…al into msarahan/one-pass-conda-test-env
|
There were some CI failures, which it looks like Rob recently fixed in PR: rapidsai/rmm#1569 Restarting the failed CI jobs Should add the failed CI jobs are unrelated to the fix that this PR is proposing (they involved wheel builds) |
|
Also blocked by rapidsai/cudf#15840 |
|
Those are both merged. What's holding this now? |
|
@harrism nothing, I just re-ran the failing jobs |
|
Was waiting for packages from those before restarting. Looks like they were uploaded ~20mins ago. So hopefully now things clear up |
jakirkham
added
5 - Ready to Merge
|
Thanks all! 🙏 |
Description
This is a port of rapidsai/cuml#5781 and part of rapidsai/build-planning#22
Checklist