Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use a static gtest and gbench #1377

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Always use a static gtest and gbench #1377

merged 2 commits into from
Apr 26, 2024

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Apr 25, 2024 •
edited
Loading

Description

Use static GTest and Benchmark.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@trxcllnt trxcllnt requested review from a team as code owners April 25, 2024 21:44
@github-actions github-actions bot added conda Related to conda and conda configuration cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Apr 25, 2024
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 25, 2024
@trxcllnt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 37f35f8 into rapidsai:branch-24.06 Apr 26, 2024
69 of 70 checks passed
@trxcllnt trxcllnt deleted the fix/static-test-dependencies branch April 26, 2024 17:33
@robertmaynard robertmaynard mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@isVoid isVoid isVoid approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @robertmaynard @isVoid @AyodeAwe