Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ListColumn instead of build_list_column #1327

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Use ListColumn instead of build_list_column #1327

merged 4 commits into from
Feb 1, 2024

Conversation

mroeschke
Copy link
Contributor

Description

This API is planned for removal in cudf: rapidsai/cudf#14786

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner January 22, 2024 21:39
@mroeschke mroeschke requested review from harrism and isVoid January 22, 2024 21:39
@github-actions github-actions bot added the Python Related to Python code label Jan 22, 2024
@mroeschke mroeschke mentioned this pull request Jan 22, 2024
Merged
3 tasks
harrism
harrism approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting out in front with this one!

@harrism harrism added feature request New feature or request non-breaking Non-breaking change labels Jan 22, 2024
isVoid
isVoid approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@harrism harrism changed the title Use ListColumn over build_list_column Use ListColumn instead of build_list_column Jan 31, 2024
@harrism
Copy link
Member

harrism commented Jan 31, 2024

/merge

@harrism
Copy link
Member

harrism commented Jan 31, 2024

Pytests still failing due to _from_columns?

@rapids-bot rapids-bot bot merged commit 6113f5f into rapidsai:branch-24.02 Feb 1, 2024
61 checks passed
@mroeschke mroeschke deleted the fix/build_columns branch February 1, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@harrism harrism harrism approved these changes

Assignees

@mroeschke mroeschke

Labels
feature request New feature or request non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @harrism @isVoid