Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit initial size to all pools and avoid RMM detail APIs #1319

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Add explicit initial size to all pools and avoid RMM detail APIs #1319

merged 2 commits into from
Jan 16, 2024

Conversation

harrism
Copy link
Member

@harrism harrism commented Jan 11, 2024

This PR fixes up cuSpatial to avoid usage that will soon be deprecated in RMM.

Depends on rapidsai/rmm#1417

Fixes #1318

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
@harrism harrism self-assigned this Jan 11, 2024
@harrism harrism requested a review from a team as a code owner January 11, 2024 01:58
@harrism harrism requested review from trxcllnt and isVoid January 11, 2024 01:58
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Jan 11, 2024
@harrism
Copy link
Member Author

harrism commented Jan 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 43bb8f3 into rapidsai:branch-24.02 Jan 16, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@harrism harrism

Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Update cuSpatial to always explicitly specify RMM pool size and avoid using rmm::detail APIs
2 participants
@harrism @isVoid