-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CUSPATIAL_BUILD_WHEELS and standardize Python builds #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Dec 5, 2023
github-actions
bot
added
cmake
Related to CMake code or build configuration
Python
Related to Python code
ci
labels
Dec 5, 2023
harrism
approved these changes
Dec 6, 2023
Co-authored-by: Mark Harris <783069+harrism@users.noreply.github.com>
raydouglass
approved these changes
Dec 6, 2023
/merge |
trxcllnt
reviewed
Feb 1, 2024
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
This fixes an error introduced in #1304. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mark Harris (https://github.com/harrism) - Paul Taylor (https://github.com/trxcllnt) - Ray Douglass (https://github.com/raydouglass) URL: #1334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
cmake
Related to CMake code or build configuration
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Related to Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some minor simplification in advance of the scikit-build-core migration to better align wheel and non-wheel Python builds. Additionally, this PR simplifies handling of the nvcomp targets and their installation.
Checklist