Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify wheel build scripts and allow alphas of RAPIDS dependencies #1264

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Simplify wheel build scripts and allow alphas of RAPIDS dependencies #1264

merged 5 commits into from
Sep 8, 2023

Conversation

divyegala
Copy link
Member

Description

This PR:

  1. Removes ci/apply_wheel_modifications.sh and uses it inline in wheel build scripts
  2. Allows for specifying alpha versioned dependencies of RAPIDS projects

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@divyegala divyegala requested a review from a team as a code owner September 7, 2023 18:53
@github-actions github-actions bot added the ci label Sep 7, 2023
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 8, 2023
vyasr
vyasr approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise good.

ci/build_wheel.sh Outdated Show resolved Hide resolved
@divyegala @vyasr
Update ci/build_wheel.sh
ce769ed 
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a8adea4 into rapidsai:branch-23.10 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@divyegala @ajschmidt8 @vyasr