Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-merge branch-23.06 to branch-23.08 #1171

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Forward-merge branch-23.06 to branch-23.08 #1171

merged 1 commit into from
Jun 6, 2023

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-23.06 that creates a PR to keep branch-23.08 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

@trxcllnt
cuSpatial pip packages (#1148)
4b76c44 
Initial draft PR to build statically linked cuspatial wheels.

Closes #869.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - H. Thomson Comer (https://github.com/thomcom)
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)
  - Mark Harris (https://github.com/harrism)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1148
@GPUtester GPUtester requested review from a team as code owners June 2, 2023 01:38
@GPUtester GPUtester requested review from vyasr and trxcllnt June 2, 2023 01:38
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@GPUtester
Copy link
Contributor Author

FAILURE - Unable to forward-merge due to conflicts, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/
IMPORTANT: Before merging and approving this PR, be sure to change the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

@github-actions github-actions bot added ci cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Jun 2, 2023
@trxcllnt trxcllnt mentioned this pull request Jun 5, 2023
Merged
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.08@f07ac48). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-23.08    #1171   +/-   ##
===============================================
  Coverage                ?   91.50%           
===============================================
  Files                   ?       38           
  Lines                   ?     1990           
  Branches                ?        0           
===============================================
  Hits                    ?     1821           
  Misses                  ?      169           
  Partials                ?        0

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raydouglass raydouglass merged commit ddf831d into branch-23.08 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
ci cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GPUtester @codecov-commenter @raydouglass @trxcllnt