Move experimental headers into main include/cuspatial directory
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
improvement
harrism
changed the title
experimental headers into main include/cuspatial directory
3 tasks
thomcom
approved these changes
Apr 25, 2023
isVoid
approved these changes
Apr 25, 2023
| @@ -52,7 +55,7 @@ Testing header-only APIs requires CUDA compilation so should be done in `.cu` fi | |||
|
|
|||
| ## Base Fixture | |||
|
|
|||
| All libcuspatial unit tests should make use of a GTest | |||
| All libcuspatial unit tests should make use of a GTest | |||
There was a problem hiding this comment.
I think here we should encourage the use of cuspatial::test::BaseFixture?
https://github.com/rapidsai/cuspatial/blob/branch-23.06/cpp/include/cuspatial_test/base_fixture.hpp
There was a problem hiding this comment.
I think that should be a separate PR.
| @@ -65,7 +68,7 @@ Example: | |||
|
|
|||
| ## Typed Tests | |||
There was a problem hiding this comment.
We also support value-parameterized test now:
There was a problem hiding this comment.
Separate PR (same as above).
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1083.
include/cuspatial/. This works without conflicts because header-only API headers have the.cuhextension while column-based API headers have the.cppextension.experimentaland also renames theREFACTORING_GUIDE.mdtoHEADER_ONLY_API_GUIDE.mdand updates it.Checklist