Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Benchmark ST_Distance #994

Closed
isVoid opened this issue Mar 14, 2023 · 1 comment · Fixed by #1277
Closed

[FEA]: Benchmark ST_Distance #994

isVoid opened this issue Mar 14, 2023 · 1 comment · Fixed by #1277
Assignees
Labels
feature request New feature or request

Comments

@isVoid
Copy link
Contributor

isVoid commented Mar 14, 2023

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

Update 06/05/2023:

This line of work is now being divided into two steps:

  1. Making a good geometry generator that generates a varied distribution of geometry arrays.
  2. Write benchmarks for the distance APIs and report findings.

Original

We need to write a comprehensive test suite for ST_distance components to understand how the current kernels performs. This can also help answer all sorts of small performance suggestions in code review.

Describe any alternatives you have considered

No response

Additional context

No response

@isVoid isVoid added feature request New feature or request Needs Triage Need team to review and classify labels Mar 14, 2023
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Apr 27, 2023
@isVoid isVoid self-assigned this Jun 5, 2023
@isVoid
Copy link
Contributor Author

isVoid commented Jun 5, 2023

Part of this work is blocking #1061, without benchmarking the kernels we cannot make a decision when to switch to alternative kernel designs.

@isVoid isVoid mentioned this issue Oct 5, 2023
12 tasks
@rapids-bot rapids-bot bot closed this as completed in #1277 Oct 5, 2023
rapids-bot bot pushed a commit that referenced this issue Oct 5, 2023
closes #994 
There are primitive benchmark results for `GeoSeries.distance` in #1231. This PR plans to add more benchmark coverage:
TODO:
- [x] point-point
- [x] point-linestring
- [x] point-polygon
- [x] linestring-linestring
- [x] linestring-polygon
- [x] polygon-polygon
- [x] Geometry complexity dimension
- [x] Geometry spatial relationship dimension
- [ ] Write the blog

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1277
@github-project-automation github-project-automation bot moved this from Todo to Done in cuSpatial Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants