Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Implement binary predicates that depend on equals #832

Closed
thomcom opened this issue Dec 1, 2022 · 0 comments · Fixed by #926
Closed

[FEA]: Implement binary predicates that depend on equals #832

thomcom opened this issue Dec 1, 2022 · 0 comments · Fixed by #926
Assignees
Labels
feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Milestone

Comments

@thomcom
Copy link
Contributor

thomcom commented Dec 1, 2022

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem you would like to solve.

Is your feature request related to a problem? Please describe.
Some spatial predicates depend only on the outcome of point-in-polygon.

Describe the solution you'd like
I can work on these predicates in python while the equals and intersects basic predicates are being worked on.

Equality/Intersection/PIP table
Legend:
x: False/impossible
e: uses equality
i: uses intersection
p: uses pip

  x(p, p) x(p, l) x(p, P) x(l, p) x(l, l) x(l, P) x(P, p) x(P, l) x(P, P)
Equals e x x x e e e e e
Disjoint e e e i i ip ep ep ep
Touches e e p i i ip ip ip ip
Contains e x x i e x p p p
Covers e x x i e x ip ip ip
Intersects e e p i i i ip ip ip
Within e e p x e p x x p
CoveredBy e e p x e p x x p
Crosses e x x i i i p i i
Overlaps e x x i i i p i i

#832 (comment)

Describe any alternatives you have considered

No response

Additional context

No response

@thomcom thomcom added feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2022
@thomcom thomcom added this to the DE-9IM milestone Dec 1, 2022
@thomcom thomcom self-assigned this Dec 1, 2022
@thomcom thomcom added this to cuSpatial Dec 1, 2022
@thomcom thomcom moved this to In Progress in cuSpatial Dec 1, 2022
@harrism harrism moved this from In Progress to Review in cuSpatial Dec 12, 2022
@thomcom thomcom moved this from Review to Done in cuSpatial Mar 21, 2023
@rapids-bot rapids-bot bot closed this as completed in #926 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
1 participant