Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Issues with expect_vector_equivalent test utility #772

Closed
harrism opened this issue Nov 3, 2022 · 0 comments · Fixed by #777
Closed

[BUG] Issues with expect_vector_equivalent test utility #772

harrism opened this issue Nov 3, 2022 · 0 comments · Fixed by #777
Assignees
@isVoid
Labels
bug Something isn't working tests Relating to tests and test automation

Comments

@harrism
Copy link
Member

harrism commented Nov 3, 2022

Describe the bug

  1. We should move the header https://github.com/rapidsai/cuspatial/blob/branch-22.12/cpp/tests/utility/vector_equality.hpp to include/cudf_test/vector_equality.hpp
  2. The call to expect_vector_equivalent in the macro here:

    cuspatial/cpp/tests/utility/vector_equality.hpp

    Line 175 in 92c3a08

    expect_vector_equivalent(lhs, rhs, ##__VA_ARGS__); \
    should be qualified with the namespace cudf::test. Also, unit tests should not be put inside that namespace, only test utilities.
  3. The setprecision() calls should be changed to use the maximum decimal digits of the type being checked (float or double)

  4. cuspatial/cpp/tests/utility/vector_equality.hpp

    Line 60 in 92c3a08

    return ::testing::FloatNear(val, abs_error);
    this line should use DoubleNear, not FloatNear.
@harrism harrism added bug Something isn't working tests Relating to tests and test automation c++ labels Nov 3, 2022
@harrism harrism added this to cuSpatial Nov 3, 2022
@jarmak-nv jarmak-nv moved this to In Progress in cuSpatial Nov 3, 2022
@isVoid isVoid self-assigned this Nov 3, 2022
@isVoid isVoid mentioned this issue Nov 3, 2022
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #777 Nov 8, 2022
rapids-bot bot pushed a commit that referenced this issue Nov 8, 2022
@isVoid
address issue with vector equivalent utility (#777)
48fbedf 
Closes #772 , Address various issue with vector equivalent utility.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #777
Repository owner moved this from In Progress to Done in cuSpatial Nov 8, 2022
@harrism harrism removed the c++ label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isVoid isVoid

Labels
bug Something isn't working tests Relating to tests and test automation
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

address issue with vector equivalent utility isVoid/cuspatial
2 participants
@harrism @isVoid