-
Notifications
You must be signed in to change notification settings - Fork 156
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use CuPy array in
pip_bitmap_column_to_binary_array
(#1418)
The performance regression in #1413 is due to numba's `DeviceNDArray` is slow in slicing. Recent cudf's DataFrame construction has simplified the construction and delegated construction to similar logic that handles __cuda_array_interface__. Since the construction involves slicing the array, we need this operation to be fast. In that sense, we should cast the use of DeviceNDArray to cupy array to support fast slicing. closes #1413 Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Paul Taylor (https://github.com/trxcllnt) - Mark Harris (https://github.com/harrism) - https://github.com/jakirkham URL: #1418
- Loading branch information
Showing
2 changed files
with
9 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters