Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #6012

Merged

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 7, 2024

Contributes to rapidsai/build-planning#58.

scikit-build-core==0.10.0 was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it.

This proposes upgrading to that version and fixing configuration here in a way that:

  • is compatible with that new scikit-build-core version
  • takes advantage of the forward-compatibility mechanism (minimum-version) that scikit-build-core provides, to reduce the risk of needing to do this again in the future

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 7, 2024
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Aug 7, 2024
@jameslamb jameslamb changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 14:13
@jameslamb
Copy link
Member Author

The devcontainers build should be fixed once rapidsai/devcontainers#377 is merged. Otherwise, this is ready for review.

@jameslamb jameslamb changed the title WIP: Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Aug 7, 2024
@jameslamb jameslamb marked this pull request as ready for review August 7, 2024 15:27
@jameslamb jameslamb requested a review from a team as a code owner August 7, 2024 15:27
@jameslamb jameslamb requested a review from raydouglass August 7, 2024 15:27
@jakirkham
Copy link
Member

Restarting failed CI jobs now that devcontainers have been updated

@jakirkham
Copy link
Member

/merge

@jameslamb
Copy link
Member Author

CI will be failing here until this is addressed: #6017

@rapids-bot rapids-bot bot merged commit 0def703 into rapidsai:branch-24.10 Aug 9, 2024
62 checks passed
@jameslamb jameslamb deleted the scikit-build-core-version branch August 9, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants