-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use workflow branch 24.08 again #5970
Merged
rapids-bot
merged 1 commit into
rapidsai:branch-24.08
from
KyleFromNVIDIA:revert-cuda-12.5.1
Jul 19, 2024
Merged
Use workflow branch 24.08 again #5970
rapids-bot
merged 1 commit into
rapidsai:branch-24.08
from
KyleFromNVIDIA:revert-cuda-12.5.1
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleFromNVIDIA
added
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Jul 19, 2024
jameslamb
approved these changes
Jul 19, 2024
jakirkham
approved these changes
Jul 19, 2024
One test was slightly off from its tolerance on CI: ____________ test_tsne_distance_metrics_on_sparse_input[cosine-fft] ____________
[gw7] linux -- Python 3.10.14 /opt/conda/envs/test/bin/python
method = 'fft', metric = 'cosine'
@pytest.mark.parametrize("method", ["fft", "barnes_hut", "exact"])
@pytest.mark.parametrize(
"metric", ["l2", "euclidean", "cityblock", "l1", "manhattan", "cosine"]
)
def test_tsne_distance_metrics_on_sparse_input(method, metric):
data, labels = make_blobs(
n_samples=1000, n_features=64, centers=5, random_state=42
)
data_sparse = scipy.sparse.csr_matrix(data)
cuml_tsne = TSNE(
n_components=2,
random_state=1,
n_neighbors=DEFAULT_N_NEIGHBORS,
method=method,
learning_rate_method="none",
min_grad_norm=1e-12,
perplexity=DEFAULT_PERPLEXITY,
metric=metric,
)
if method == "fft":
sk_tsne = skTSNE(
n_components=2,
random_state=1,
min_grad_norm=1e-12,
method="barnes_hut",
perplexity=DEFAULT_PERPLEXITY,
metric=metric,
init="random",
)
else:
sk_tsne = skTSNE(
n_components=2,
random_state=1,
min_grad_norm=1e-12,
method=method,
perplexity=DEFAULT_PERPLEXITY,
metric=metric,
init="random",
)
cuml_embedding = cuml_tsne.fit_transform(data_sparse)
nans = np.sum(np.isnan(cuml_embedding))
sk_embedding = sk_tsne.fit_transform(data_sparse)
cu_trust = trustworthiness(data, cuml_embedding, metric=metric)
sk_trust = trustworthiness(data, sk_embedding, metric=metric)
> assert cu_trust > 0.85
E assert 0.8022727822580645 > 0.85 Restarted it In any event this is unrelated to this change |
Looks like we got passed that point in the restart |
/merge |
1 similar comment
/merge |
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating everything to CUDA 12.5.1, use
shared-workflows@branch-24.08
again.Contributes to rapidsai/build-planning#73