Pulling test/prims/test_utils.h out of raft namespace and into MLCommon #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
bug
…emove_raft_abs_redefinition
…ition' into bug-2302-remove_raft_abs_redefinition
dantegd
approved these changes
Jan 24, 2023
|
@dantegd CI seems to be picking up an older version of the raft conda packages (as you had suggested offline): https://github.com/rapidsai/cuml/actions/runs/3991712271/jobs/6846916279#step:6:481. Do you have any thoughts as to how we can/should make it pick up the most recent or does that require #5120 to be merged first? I can also merge that into my branch here, but then we'd still have to wait for that PR to be completed. |
|
This PR was merged into another already. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the
test_utils.hincpp/test/primswas using theraftnamespace, which was causing this file to attempt to redefine anabsfunction. Changing the namespace back toMLCommonhere to remove this conflict.