Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Updated CONTRIBUTING.md #395

Merged
merged 10 commits into from
Apr 28, 2019
Merged

[REVIEW] Updated CONTRIBUTING.md #395

merged 10 commits into from
Apr 28, 2019
+28 −111

Conversation

Salonijain27
Copy link
Contributor

No description provided.

Salonijain27 added 4 commits March 27, 2019 07:12
Update CONTRIBUTING.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
76ce482
Update CHANGELOG.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1ee3c46
Merge branch 'branch-0.7' into branch-0.7

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a90e199
Update CONTRIBUTING.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5543365
@dantegd
Copy link
Member

dantegd commented Mar 27, 2019

rerun tests

Update test_dbscan.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f9acbd7
cjnolet
cjnolet requested changes Mar 29, 2019
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saloni, thank you so much for doing this!

I gave it a quick proofread, mostly just to validate that it is relevant to the expected audience (general public vs internal NVIDIA).

@cjnolet cjnolet self-requested a review March 29, 2019 01:08
Salonijain27 added 2 commits March 29, 2019 06:40
Update test_dbscan.py

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f588159
Update CONTRIBUTING.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
ed77988
dantegd
dantegd requested changes Apr 1, 2019
View reviewed changes
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review doc Documentation labels Apr 1, 2019
Salonijain27 added 3 commits April 23, 2019 16:54
Update CONTRIBUTING.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
17e415d
Update CONTRIBUTING.md

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8d6e5bf
Merge branch 'branch-0.7' into branch-0.7

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
d6843b0
@Salonijain27
Copy link
Contributor Author

Salonijain27 commented Apr 24, 2019 •
edited
Loading

made the required changes as requested by @cjnolet and @dantegd

@cjnolet
Copy link
Member

cjnolet commented Apr 26, 2019

rerun tests

@dantegd dantegd merged commit cc157f9 into rapidsai:branch-0.7 Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd

@cjnolet cjnolet

Assignees
No one assigned
Labels
4 - Waiting on Author Waiting for author to respond to review doc Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Salonijain27 @dantegd @cjnolet