Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #4597

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 7, 2024

Contributes to rapidsai/build-planning#58.

scikit-build-core==0.10.0 was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it.

This proposes upgrading to that version and fixing configuration here in a way that:

  • is compatible with that new scikit-build-core version
  • takes advantage of the forward-compatibility mechanism (minimum-version) that scikit-build-core provides, to reduce the risk of needing to do this again in the future

@jameslamb jameslamb changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 14:09
@jakirkham
Copy link
Member

Thanks James! 🙏

Appears to be marked draft/WIP. What else is still needed here?

@jameslamb
Copy link
Member Author

Appears to be marked draft/WIP. What else is still needed here?

Most of the CI jobs failed, in a way that looked to me like what we've seen before when the runners run out of memory. I'm not sure if that was because of some infrastructure-level issues or because we just weren't getting many cache hits from sccache.

Didn't want to put this up for review until more things were passing.

I've just restarted CI, let's see how it goes.

@jameslamb jameslamb changed the title WIP: Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version Aug 8, 2024
@jameslamb jameslamb marked this pull request as ready for review August 8, 2024 16:34
@jameslamb jameslamb requested a review from a team as a code owner August 8, 2024 16:34
@jameslamb jameslamb requested a review from msarahan August 8, 2024 16:34
Copy link
Contributor

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failures look like CUDF API stuff. Definitely orthogonal to this change. I think this PR is fine.

@jameslamb
Copy link
Member Author

Thanks @msarahan !

And in fact, looks like @nv-rliu just merged a PR that should fix those: CI issues: #4600

I just merged latest branch-24.10 in here to pull those fixes in.

@jameslamb
Copy link
Member Author

/merge

@jameslamb
Copy link
Member Author

(just queuing that to auto-merge whenever the tests run)

@rapids-bot rapids-bot bot merged commit f935e76 into rapidsai:branch-24.10 Aug 9, 2024
137 checks passed
@jameslamb jameslamb deleted the scikit-build-core-version branch August 9, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants