-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #4597
Use tool.scikit-build.cmake.version, set scikit-build-core minimum-version #4597
Conversation
Thanks James! 🙏 Appears to be marked draft/WIP. What else is still needed here? |
Most of the CI jobs failed, in a way that looked to me like what we've seen before when the runners run out of memory. I'm not sure if that was because of some infrastructure-level issues or because we just weren't getting many cache hits from Didn't want to put this up for review until more things were passing. I've just restarted CI, let's see how it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failures look like CUDF API stuff. Definitely orthogonal to this change. I think this PR is fine.
/merge |
(just queuing that to auto-merge whenever the tests run) |
Contributes to rapidsai/build-planning#58.
scikit-build-core==0.10.0
was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it.This proposes upgrading to that version and fixing configuration here in a way that:
scikit-build-core
versionminimum-version
) thatscikit-build-core
provides, to reduce the risk of needing to do this again in the future