Add CUDA_STATIC_MATH_LIBRARIES #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the CUDA math libraries is independent of the CUDA runtime. Make their static/shared status separately controllable.
KyleFromNVIDIA
added
improvement
robertmaynard
approved these changes
Jul 8, 2024
vyasr
approved these changes
Jul 8, 2024
|
/merge |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/cugraph
that referenced
this pull request
Aug 15, 2024
In rapidsai#4526, we introduced the CUDA_STATIC_MATH_LIBRARIES option and set it to OFF by default. We did not set it to ON in the Python builds, and as a result ended up bundling dynamic CUDA libraries. Set the option to ON in the Python build.
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
In #4526, we introduced the CUDA_STATIC_MATH_LIBRARIES option and set it to OFF by default. We did not set it to ON in the Python builds, and as a result ended up bundling dynamic CUDA libraries. Set the option to ON in the Python build. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #4612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the CUDA math libraries is independent of the CUDA runtime. Make their static/shared status separately controllable.
Contributes to rapidsai/build-planning#35