Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rapids-build-backend #4393

Merged
merged 65 commits into from
Jul 1, 2024
Merged

Use rapids-build-backend #4393

merged 65 commits into from
Jul 1, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented May 7, 2024 •
edited by jameslamb
Loading

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing rapids-build-backend as this project's build backend, to reduce the complexity of various CI/build scripts.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners May 7, 2024 19:18
@github-actions github-actions bot added the conda label May 8, 2024
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request May 15, 2024
Closed
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels May 16, 2024
@jameslamb jameslamb mentioned this pull request Jun 17, 2024
Merged
@jameslamb
Copy link
Member

The test failures look like this issue unrelated to this PR: #4496 (comment).

I believe this PR is now ready for review.

@jameslamb jameslamb removed the request for review from a team June 27, 2024 17:23
@jameslamb jameslamb self-assigned this Jul 1, 2024
@BradReesWork
Copy link
Member

LGTM from a doc codeowner perspective

@jameslamb
Copy link
Member

The other changes on branch-24.08 since this was last built don't look like they'd affect or be affected by these changes, so I'm going to merge this. Thanks everyone!

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 538a2ce into rapidsai:branch-24.08 Jul 1, 2024
131 checks passed
naimnv pushed a commit to naimnv/cugraph-forked that referenced this pull request Jul 2, 2024
Revert "Use rapids-build-backend (rapidsai#4393)"
4016e2f 
This reverts commit 538a2ce.
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Jul 2, 2024
Merged
naimnv pushed a commit to naimnv/cugraph-forked that referenced this pull request Jul 2, 2024
Revert "Revert "Use rapids-build-backend (rapidsai#4393)""
530c61b 
This reverts commit 4016e2f.
@jameslamb jameslamb mentioned this pull request Jul 24, 2024
Open
@jameslamb jameslamb mentioned this pull request Oct 15, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb left review comments

@msarahan msarahan msarahan approved these changes

@vyasr vyasr vyasr approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@bdice bdice Awaiting requested review from bdice

Assignees

@jameslamb jameslamb

Labels
ci conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.
6 participants
@KyleFromNVIDIA @rlratzel @jameslamb @BradReesWork @msarahan @vyasr