Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix PyPI URL in docs #4282

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

jameslamb
Copy link
Member

https://pypi.ngc.nvidia.com was retired a while ago, and RAPIDS wheels are now available from https://pypi.nvidia.com (see https://docs.rapids.ai/install).

This proposes removing one lingering reference to pypi.ngc.nvidia.com left over in this project's docs.

How I tested this

docker run \
   --rm \
   python:3.10 \
   pip install --dry-run cugraph-cu12 --extra-index-url=https://pypi.nvidia.com

saw the expected output

Collecting cugraph-cu12
  Downloading https://pypi.nvidia.com/cugraph-cu12/cugraph_cu12-24.2.0-cp310-cp310-manylinux_2_28_aarch64.whl (1318.6 MB)

This is the only use of that ngc.nvidia.com URL in this project.

git grep -E 'ngc\.'

@jameslamb jameslamb added bug Something isn't working doc Documentation non-breaking Non-breaking change labels Mar 26, 2024
@jameslamb jameslamb requested a review from a team as a code owner March 26, 2024 17:20
@acostadon acostadon removed the bug Something isn't working label Mar 26, 2024
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Chanks for catching this.

@acostadon acostadon added this to the 24.06 milestone Mar 26, 2024
@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 8e89267 into rapidsai:branch-24.06 Apr 5, 2024
132 checks passed
@jameslamb jameslamb deleted the docs/pypi-link branch April 5, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants