Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SG notebook #4169

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Update SG notebook #4169

merged 7 commits into from
Feb 15, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Feb 13, 2024 •
edited
Loading

Update SG notebook to handle a handle a couple of cases where the current notebook would fail for unweighted graph and if the graph doesn't have node id 0.

Changes for SG notebook:

  • For graphs without weights, run bfs instead of sssp.
  • For the input graph doesn't have node with id 0, peek an existing node id as seed for BFS and SSP
  • simplify bookkeeping for run statistics

Changes for MG notebook:

  • Call SSSP or BFS based on weighted attribute

@naimnv naimnv requested a review from a team as a code owner February 13, 2024 18:41
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 13, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@naimnv naimnv added non-breaking Non-breaking change bug Something isn't working labels Feb 13, 2024
@naimnv naimnv self-assigned this Feb 13, 2024
@naimnv naimnv added this to the 24.04 milestone Feb 13, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Feb 13, 2024

/ok to test

@naimnv naimnv changed the title Update SG notebook to handle a handle a couple of cases where the current notebook run fails Update SG notebook to handle a handle a couple of cases where the current notebook would fail if the graph doesn't have node id 0 Feb 13, 2024
@naimnv naimnv changed the title Update SG notebook to handle a handle a couple of cases where the current notebook would fail if the graph doesn't have node id 0 Update SG notebook Feb 13, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Feb 13, 2024

/ok to test

@naimnv
Copy link
Contributor Author

naimnv commented Feb 13, 2024

/ok to test

acostadon
acostadon requested changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great
Did you test this on multi-GPU, if so please note what GPU's were used in the header.

acostadon
acostadon approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@naimnv
Copy link
Contributor Author

naimnv commented Feb 14, 2024

Changes look great Did you test this on multi-GPU, if so please note what GPU's were used in the header.

For synth_release_single_node_multi_gpu.ipynb the hardware is now 2xRTX A600
For synth_release_single_gpu.ipynb the hardware is RTX A600

@naimnv naimnv closed this Feb 14, 2024
@naimnv naimnv reopened this Feb 14, 2024
@naimnv
Copy link
Contributor Author

naimnv commented Feb 14, 2024

/ok to test

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a094799 into rapidsai:branch-24.04 Feb 15, 2024
121 of 122 checks passed
@raydouglass raydouglass mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostadon acostadon acostadon approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@jnke2016 jnke2016 Awaiting requested review from jnke2016

Assignees

@naimnv naimnv

Labels
bug Something isn't working non-breaking Non-breaking change python
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
3 participants
@naimnv @BradReesWork @acostadon