-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dask_cudf
dataframe for the _make_plc_graph
while creating cugraph.Graph
#3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VibhuJawa
added
non-breaking
Non-breaking change
CRITICAL BUG!
BUG that needs to be FIX NOW !!!!
bug
Something isn't working
and removed
CRITICAL BUG!
BUG that needs to be FIX NOW !!!!
labels
Sep 28, 2023
/ok to test |
1 similar comment
/ok to test |
VibhuJawa
changed the title
[WIP] Remove
[WIP] Remove Sep 28, 2023
dask_cudf
dataframe use while creating dask_cudf dask_cudf
dataframe use while creating cugraph.Graph
VibhuJawa
changed the title
[WIP] Remove
[WIP] Remove Sep 28, 2023
dask_cudf
dataframe use while creating cugraph.Graph dask_cudf
dataframe for the _make_plc_graph
while creating cugraph.Graph
/ok to test |
rlratzel
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vibhu!
BradReesWork
changed the title
[WIP] Remove
Remove Sep 29, 2023
dask_cudf
dataframe for the _make_plc_graph
while creating cugraph.Graph
dask_cudf
dataframe for the _make_plc_graph
while creating cugraph.Graph
/ok to test |
/ok to test |
1 similar comment
/ok to test |
rlratzel
approved these changes
Oct 2, 2023
jnke2016
approved these changes
Oct 2, 2023
/ok to test |
/merge |
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix #3790
Please note that I have not being able to cause failure locally so it is really hard for me to know if it actually fixes anything or not .
MRE being used to test locally: https://gist.github.com/VibhuJawa/4b1ec24022b6e2dd7879cd2e8d3fab67
CC: @jnke2016 , @rlratzel ,
CC: @rjzamora , Please let me know what i can do better here.