Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dask_cudf dataframe for the _make_plc_graph while creating cugraph.Graph #3895

Merged
merged 5 commits into from
Oct 5, 2023

Conversation

VibhuJawa
Copy link
Member

This PR attempts to fix #3790

Please note that I have not being able to cause failure locally so it is really hard for me to know if it actually fixes anything or not .

MRE being used to test locally: https://gist.github.com/VibhuJawa/4b1ec24022b6e2dd7879cd2e8d3fab67

CC: @jnke2016 , @rlratzel ,

CC: @rjzamora , Please let me know what i can do better here.

@VibhuJawa VibhuJawa requested a review from a team as a code owner September 28, 2023 05:49
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 28, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@VibhuJawa VibhuJawa added non-breaking Non-breaking change CRITICAL BUG! BUG that needs to be FIX NOW !!!! bug Something isn't working and removed CRITICAL BUG! BUG that needs to be FIX NOW !!!! labels Sep 28, 2023
@VibhuJawa
Copy link
Member Author

/ok to test

1 similar comment
@VibhuJawa
Copy link
Member Author

/ok to test

@VibhuJawa VibhuJawa changed the title [WIP] Remove dask_cudf dataframe use while creating dask_cudf [WIP] Remove dask_cudf dataframe use while creating cugraph.Graph Sep 28, 2023
@VibhuJawa VibhuJawa changed the title [WIP] Remove dask_cudf dataframe use while creating cugraph.Graph [WIP] Remove dask_cudf dataframe for the _make_plc_graph while creating cugraph.Graph Sep 28, 2023
@BradReesWork BradReesWork added this to the 23.10 milestone Sep 28, 2023
@rlratzel
Copy link
Contributor

/ok to test

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vibhu!

@BradReesWork BradReesWork changed the title [WIP] Remove dask_cudf dataframe for the _make_plc_graph while creating cugraph.Graph Remove dask_cudf dataframe for the _make_plc_graph while creating cugraph.Graph Sep 29, 2023
@VibhuJawa VibhuJawa added the DO NOT MERGE Hold off on merging; see PR for details label Sep 29, 2023
@rlratzel
Copy link
Contributor

/ok to test

@ChuckHastings
Copy link
Collaborator

/ok to test

1 similar comment
@alexbarghi-nv
Copy link
Member

/ok to test

@VibhuJawa VibhuJawa removed the DO NOT MERGE Hold off on merging; see PR for details label Oct 4, 2023
@rlratzel
Copy link
Contributor

rlratzel commented Oct 4, 2023

/ok to test

@BradReesWork
Copy link
Member

/merge

@BradReesWork
Copy link
Member

/ok to test

@rapids-bot rapids-bot bot merged commit d03cb0f into rapidsai:branch-23.10 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph creation fails when copying the dask input dataframe
6 participants