-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing util improvements and refactoring #3705
Testing util improvements and refactoring #3705
Conversation
Merging 15 commits from Jul 18-24
Merge commits from 7/18 to 7/24 (18 total)
Merging commits from Aug 2-3
8114449
to
95685db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting to look good for a first pass. We'll eventually refactor quite a lot of the fixtures out on future PRs, but just replacing Nx calls initially is a good start.
We need to get the resultset data uploaded and the rest of the download/unpack code written to fully test end-to-end and get this passing CI.
e8d9a82
to
2a92f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/merge |
closes #2416
Removes a dependency when running python tests, which will speed up test runs. Also introduces a new testing component (
Resultset
) to clean up unit tests by generating golden results and storing them locally/on the cloud. This PR is focused on tests from thetraversal
category.NOTE: Devs will download specific golden results from the cloud to avoid local overhead.