-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependency versions for 23.08
#3638
Fix dependency versions for 23.08
#3638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Aligns with recent changes in other repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the addition of the DEPENDENCIES label. This should make it easier to recognize what we're changing... as well as simplifying the script a bit and reducing the opportunity for copy/paste errors.
/merge |
Updates `update-version.sh` to follow the pattern from rapidsai/cugraph#3638 Required for `23.06` because `python/cuspatial/pyproject.py` does not exist thus breaking the script. This means any hotfixes to this version will have issues during release. Also updates a version in `cpp/doxygen/Doxyfile` which was outdated. Skipped CI since this script is not tested by CI. Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - AJ Schmidt (https://github.com/ajschmidt8)
This PR fixes all of the RAPIDS dependency versions for
branch-23.08
.The processes around
update-version.sh
will eventually be improved in the future.For now, this manual fix will resolve the current issues on
branch-23.08
.The script can be (and was) tested locally by running commands like: