Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency versions for 23.08 #3638

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

ajschmidt8
Copy link
Member

This PR fixes all of the RAPIDS dependency versions for branch-23.08.

The processes around update-version.sh will eventually be improved in the future.

For now, this manual fix will resolve the current issues on branch-23.08.

The script can be (and was) tested locally by running commands like:

bash ci/release/update-version.sh 23.08.00
bash ci/release/update-version.sh 23.10.00

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 5, 2023
@ajschmidt8 ajschmidt8 requested review from a team as code owners June 5, 2023 16:36
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Aligns with recent changes in other repos.

Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of the DEPENDENCIES label. This should make it easier to recognize what we're changing... as well as simplifying the script a bit and reducing the opportunity for copy/paste errors.

@ajschmidt8
Copy link
Member Author

/merge

@BradReesWork BradReesWork added this to the 23.08 milestone Jun 5, 2023
@rapids-bot rapids-bot bot merged commit ccaf285 into rapidsai:branch-23.08 Jun 5, 2023
@ajschmidt8 ajschmidt8 deleted the fix-update-version branch June 6, 2023 21:28
raydouglass added a commit to rapidsai/cuspatial that referenced this pull request Jun 7, 2023
Updates `update-version.sh` to follow the pattern from rapidsai/cugraph#3638

Required for `23.06` because `python/cuspatial/pyproject.py` does not exist thus breaking the script. This means any hotfixes to this version will have issues during release.

Also updates a version in `cpp/doxygen/Doxyfile` which was outdated.

Skipped CI since this script is not tested by CI.

Authors:
   - Ray Douglass (https://github.com/raydouglass)

Approvers:
   - AJ Schmidt (https://github.com/ajschmidt8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants