Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build CUDA 11.8 and Python 3.10 Packages #3120

Merged
merged 10 commits into from
Jan 24, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 7, 2023

This PR updates cugraph to build against branch cuda-118 of the shared-action-workflow repository.

That branch contains updates for CUDA 11.8 and Python 3.10 packages.

It also includes some minor file renames.

Depends on rapidsai/raft#1120

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2023
@BradReesWork BradReesWork added this to the 23.02 milestone Jan 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023

Codecov Report

Base: 55.60% // Head: 55.51% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (ba367fa) compared to base (a529d76).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #3120      +/-   ##
================================================
- Coverage         55.60%   55.51%   -0.10%     
================================================
  Files               143      143              
  Lines              9318     9328      +10     
================================================
- Hits               5181     5178       -3     
- Misses             4137     4150      +13     
Impacted Files Coverage Δ
python/cugraph/cugraph/traversal/sssp.py 93.04% <100.00%> (ø)
python/cugraph/cugraph/structure/convert_matrix.py 62.60% <0.00%> (-6.96%) ⬇️
python/cugraph/cugraph/structure/graph_classes.py 78.02% <0.00%> (-1.65%) ⬇️
...raph/structure/graph_implementation/simpleGraph.py 78.45% <0.00%> (-0.49%) ⬇️
python/cugraph/cugraph/structure/property_graph.py 94.79% <0.00%> (+0.04%) ⬆️
...cugraph-pyg/cugraph_pyg/sampler/cugraph_sampler.py 76.11% <0.00%> (+0.36%) ⬆️
python/cugraph/cugraph/dask/common/input_utils.py 23.80% <0.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 marked this pull request as ready for review January 20, 2023 04:04
@ajschmidt8 ajschmidt8 requested review from a team as code owners January 20, 2023 04:04
@bdice
Copy link
Contributor Author

bdice commented Jan 23, 2023

C++ builds were broken by merging rapidsai/rapids-cmake#342. I will open a PR to revert that change in rapids-cmake.

edit: rapidsai/rapids-cmake#346

@ajschmidt8
Copy link
Member

@rlratzel, can you review this?

@ajschmidt8 ajschmidt8 requested a review from rlratzel January 24, 2023 04:57
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me.

One request though: can you briefly summarize what, if any, steps cugraph devs will need to do once this is merged? We're approaching burndown and don't want to get derailed with any surprises.

@@ -28,7 +28,7 @@ concurrency:
jobs:
cpp-build:
secrets: inherit
uses: rapidsai/shared-action-workflows/.github/workflows/conda-cpp-matrix-build.yaml@main
uses: rapidsai/shared-action-workflows/.github/workflows/conda-cpp-build.yaml@cuda-118
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious - do these eventually go back to being main, or is this a new naming convention moving forward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @ajschmidt8 has a plan for this. I am not yet sure what it will look like.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me.

One request though: can you briefly summarize what, if any, steps cugraph devs will need to do once this is merged? We're approaching burndown and don't want to get derailed with any surprises.

No further steps are necessary. Once this PR is merged, a build will kick off to publish the latest 11.8 / 3.10 packages.

It's recommended that any outstanding PRs merge in the latest changes so that they can also test against 11.8 and 3.10. But only actively developed PRs, not a bulk wholesale update since that would overload CI.

just curious - do these eventually go back to being main, or is this a new naming convention moving forward?

Yes, once all the repos are using the cuda-118 branch to build against 11.8 and publish 3.10 packages, we'll merge that branch into main and open up subsequent PRs across all the repositories to update this branch again.

I think we're just waiting for this cuml PR at this point: rapidsai/cuml#5120

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 014faf2 into rapidsai:branch-23.02 Jan 24, 2023
@bdice
Copy link
Contributor Author

bdice commented Jan 24, 2023

One request though: can you briefly summarize what, if any, steps cugraph devs will need to do once this is merged? We're approaching burndown and don't want to get derailed with any surprises.

The developer environment has changed to CUDA 11.8 to accommodate the new versions. Existing dev environments should continue to work. I don't think devs will need to take any action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants