-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CUDA 11.8 and Python 3.10 Packages #3120
Conversation
Codecov ReportBase: 55.60% // Head: 55.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3120 +/- ##
================================================
- Coverage 55.60% 55.51% -0.10%
================================================
Files 143 143
Lines 9318 9328 +10
================================================
- Hits 5181 5178 -3
- Misses 4137 4150 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
C++ builds were broken by merging rapidsai/rapids-cmake#342. I will open a PR to revert that change in |
@rlratzel, can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me.
One request though: can you briefly summarize what, if any, steps cugraph devs will need to do once this is merged? We're approaching burndown and don't want to get derailed with any surprises.
@@ -28,7 +28,7 @@ concurrency: | |||
jobs: | |||
cpp-build: | |||
secrets: inherit | |||
uses: rapidsai/shared-action-workflows/.github/workflows/conda-cpp-matrix-build.yaml@main | |||
uses: rapidsai/shared-action-workflows/.github/workflows/conda-cpp-build.yaml@cuda-118 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious - do these eventually go back to being main
, or is this a new naming convention moving forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @ajschmidt8 has a plan for this. I am not yet sure what it will look like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay to me.
One request though: can you briefly summarize what, if any, steps cugraph devs will need to do once this is merged? We're approaching burndown and don't want to get derailed with any surprises.
No further steps are necessary. Once this PR is merged, a build will kick off to publish the latest 11.8
/ 3.10
packages.
It's recommended that any outstanding PRs merge in the latest changes so that they can also test against 11.8
and 3.10
. But only actively developed PRs, not a bulk wholesale update since that would overload CI.
just curious - do these eventually go back to being main, or is this a new naming convention moving forward?
Yes, once all the repos are using the cuda-118
branch to build against 11.8
and publish 3.10
packages, we'll merge that branch into main
and open up subsequent PRs across all the repositories to update this branch again.
I think we're just waiting for this cuml
PR at this point: rapidsai/cuml#5120
/merge |
The developer environment has changed to CUDA 11.8 to accommodate the new versions. Existing dev environments should continue to work. I don't think devs will need to take any action. |
This PR updates
cugraph
to build against branch cuda-118 of theshared-action-workflow
repository.That branch contains updates for CUDA 11.8 and Python 3.10 packages.
It also includes some minor file renames.
Depends on rapidsai/raft#1120