Split edge_partition_src_dst_property.cuh to .hpp and .cuh files. #2503
Conversation
seunghwak
added
2 - In Progress
improvement
seunghwak
changed the title
…dge_src_dst_property2
seunghwak
changed the title
…dge_src_dst_property2
Codecov Report
@@ Coverage Diff @@
## branch-22.10 #2503 +/- ##
===============================================
Coverage ? 61.19%
===============================================
Files ? 106
Lines ? 5638
Branches ? 0
===============================================
Hits ? 3450
Misses ? 2188
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
rerun tests |
|
rerun tests |
| @@ -0,0 +1,119 @@ | |||
| /* | |||
| * Copyright (c) 2021-2022, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Shouldn't this be just 2022?
There was a problem hiding this comment.
I am not sure.
This file is a new file, in that sense, this should be 2022.
But the contents of this file is from another older file. That file is split to two files (and after split, significant updates, but I guess this is irrelevant in this discussion). So, in this case, the two new files should have the copyright year of just 2022 or need to inherit the copyright year of the original file? I thought the latter but will appreciate clarification.
There was a problem hiding this comment.
That wasn't clear when reviewing. I would agree that the contents of a file that originated in 2021 and is split into two files would need to keep 2021 as part of the copyright definition.
| @@ -0,0 +1,583 @@ | |||
| /* | |||
| * Copyright (c) 2021-2022, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Shouldn't this be 2022?
| @@ -0,0 +1,151 @@ | |||
| /* | |||
| * Copyright (c) 2020-2022, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
Shouldn't this just be 2022?
There was a problem hiding this comment.
Yes, this should be 2022. I will make a fix.
| fill_edge_src_property( | ||
| handle, push_graph_view, std::numeric_limits<weight_t>::max(), edge_src_distances); |
|
@gpucibot merge |
Partially addresses #2479
Code clean-up before adding
edge_property_tandupdate_edge_property(to support edge property in addition to edge weights).edge_partition_src_dst_property.cuhtoedge_src_dst_property.hpp(can be complied with g++) andedge_partition_endpoint_device_view.cuh(requires nvcc)edge_partition_src|dst_property_ttoedge_src|dst_property_tupdate_edge_partition_src_dst_property.cuhtoupdate_edge_src_dst_property.cuhandupdate_edge_partition_src|dst_propertytoupdate_edge_src|dst_property.dummy_property_ttoedge_src_dummy_property_tandedge_dst_dummy_property_tedge_src|dst_property_t'sfill()withfill_edge_src|dst_property(to allow including `edge_src_dst_property.hpp to be compiled with g++).edge_src|dst_property_view_tclasses (host side, in addition to the device_view objects which can be trivially copied to the device side); so the view() member function can be compiled with g++.