Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GraphCSC/GraphCSCView object, no longer used #2354

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Remove GraphCSC/GraphCSCView object, no longer used #2354

merged 1 commit into from
Jun 22, 2022

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jun 14, 2022 •
edited
Loading

Delete the legacy CSC graph objects. They are no longer used (all transposed=True algorithms have been migrated to the new graph objects).

Marked breaking since it deletes a C++ API feature, although should no longer be used.

@ChuckHastings ChuckHastings requested a review from a team as a code owner June 14, 2022 21:34
@ChuckHastings ChuckHastings self-assigned this Jun 14, 2022
@ChuckHastings ChuckHastings added 3 - Ready for Review improvement Improvement / enhancement to an existing function breaking Breaking change labels Jun 14, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 14, 2022
@ChuckHastings
Copy link
Collaborator Author

rerun tests

1 similar comment
@ChuckHastings
Copy link
Collaborator Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@7100fd5). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2354   +/-   ##
===============================================
  Coverage                ?   60.10%           
===============================================
  Files                   ?      102           
  Lines                   ?     5158           
  Branches                ?        0           
===============================================
  Hits                    ?     3100           
  Misses                  ?     2058           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7100fd5...04cf65e. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

rerun tests

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8587225 into rapidsai:branch-22.08 Jun 22, 2022
@ChuckHastings ChuckHastings deleted the delete_graph_csc_view branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Milestone
22.08
Development

Successfully merging this pull request may close these issues.
3 participants
@ChuckHastings @codecov-commenter @seunghwak