Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test cases and verified that algorithm works for undirected graphs #2349

Merged
merged 5 commits into from
Jul 7, 2022
Merged

added test cases and verified that algorithm works for undirected graphs #2349

merged 5 commits into from
Jul 7, 2022

Conversation

acostadon
Copy link
Contributor

closes #2239

@acostadon acostadon added bug Something isn't working multi-GPU non-breaking Non-breaking change labels Jun 8, 2022
@acostadon acostadon self-assigned this Jun 8, 2022
@acostadon
Copy link
Contributor Author

rerun tests

@rlratzel rlratzel added this to the 22.08 milestone Jun 8, 2022
@BradReesWork
Copy link
Member

rerun tests

@acostadon
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #2349 (f78faf1) into branch-22.08 (fa701f5) will increase coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.08    #2349      +/-   ##
================================================
+ Coverage         60.08%   60.10%   +0.01%     
================================================
  Files               102      102              
  Lines              5158     5158              
================================================
+ Hits               3099     3100       +1     
+ Misses             2059     2058       -1
Impacted Files Coverage Δ
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa701f5...f78faf1. Read the comment docs.

@acostadon acostadon marked this pull request as ready for review June 24, 2022 16:02
@acostadon acostadon requested a review from a team as a code owner June 24, 2022 16:02
@acostadon
Copy link
Contributor Author

rerun tests

4 similar comments
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

@acostadon
Copy link
Contributor Author

rerun tests

rlratzel
rlratzel approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note for later: in the future we'll be refactoring these to use the datasets API so we won't have to manually create paths to CSV files.

@rlratzel
Copy link
Contributor

rlratzel commented Jul 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5dd0267 into rapidsai:branch-22.08 Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees

@acostadon acostadon

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
22.08
Development

Successfully merging this pull request may close these issues.

[BUG]test_mg_degree fails with an undirected graph
4 participants
@acostadon @BradReesWork @codecov-commenter @rlratzel